feat: add support for defining an --include file #210
Conversation
My team has a use case for always requiring certain files to be included in the package.xml (these include a generated class file and test). And these files change based off of values (i.e. CI build numbers, etc) with each job run. We don't want to be submitting a new commit with each job build, but we need to include these files in the package.xml for `source:deploy`. Using this solution, we can ensure that the generated files are always included (along with `git add -f`).
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
There was a problem hiding this comment.
👏 👍 the quality is great ! and the code is very close to be approved ! Bravo
I had a few remarks (following conventional comments style)
Here are the things I think should also be included
- the new parameters should also be backported to the old command (bin/cli) (it will be deprecated soon)
- IMO
--include-destructiveshort parameter should be changed to '-N' - this PR should also test when the parameters are specified but the files does not exist (for
-nand-Nand also for-iand `-D')
I can help if you want to ! Add me to the fork
Codecov Report
@@ Coverage Diff @@
## master #210 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 20 20
Lines 482 498 +16
=========================================
+ Hits 482 498 +16
Continue to review full report at Codecov.
|
|
Hi @bbbco ! Thanks for this great contribution ! I made a review of this work, we can discuss in the thread for each items. Overall I have a questions:
|
|
Thanks for the great review! I just pushed up the changes requested. Have a great weekend! |
There was a problem hiding this comment.
Excellent contribution @bbbco , it's a great addition to the plugin, thank you!
|
Glad to help! What do we need to do to fix the |
|
Nothing, it is because the PR is from another repository, you don't have the token required to execute the job The PR title is following the guidelines |
|
Code Climate has analyzed commit d7de74b and detected 0 issues on this pull request. View more on Code Climate. |
What does this pull request contains
Explain your changes
My team has a use case for always requiring certain files to be included in the package.xml (these include a generated class file and test). And these files change based off of values (i.e. CI build numbers, etc) with each job run. We don't want to be submitting a new commit with each job build, but we need to include these files in the package.xml for
source:deploy. Using this solution, we can ensure that the generated files are always included (along withgit add -f).Does this close any currently open issues?
closes #Any particular element to being able to test locally
Any other comments?
Where has this been tested?
Operating System: Darwin Kernel Version 19.6.0: Tue Aug 24 20:28:00 PDT 2021; root:xnu-6153.141.40~1/RELEASE_X86_64
yarn version: 1.22.17
node version: v14.18.1
git version: git version 2.29.2
sfdx version: sfdx-cli/7.124.0 darwin-x64 node-v14.18.1
sgd plugin version: sfdx-git-delta 4.10.0 (link)