Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: path resolution for master detail fields #264

Merged
merged 3 commits into from
Mar 16, 2022

Conversation

scolladon
Copy link
Owner

What does this pull request contains


  • Added for new features.
  • Changed for changes in existing functionality.
  • Deprecated for soon-to-be removed features.
  • Removed for now removed features.
  • Fixed for any bug fixes.
  • Security in case of vulnerabilities.

Explain your changes


Fix the path resolution when copying master detail fields for custom object part of the delta generated sources
Now, when a custom object is should be deployed and is copied in the output folder, master detail fields of this object will also be copied

Does this close any currently open issues?


closes #263

  • Jest test to check the fix is applied are added.

Any particular element to being able to test locally


You can test with the playground
Or run the jest test

Any other comments?


Where has this been tested?


Operating System: Darwin Kernel Version 19.6.0: Thu Jan 13 01:26:33 PST 2022; root:xnu-6153.141.51~3/RELEASE_X86_64

yarn version: 1.22.15

node version: v14.19.0

git version: 2.35.1

sfdx version: sfdx-cli/7.142.1 darwin-x64 node-v14.19.0

sgd plugin version: 5.0.0

@codecov
Copy link

codecov bot commented Mar 15, 2022

Codecov Report

Merging #264 (16f6adc) into main (4da80a6) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #264   +/-   ##
=======================================
  Coverage   98.63%   98.63%           
=======================================
  Files          22       22           
  Lines         585      585           
=======================================
  Hits          577      577           
  Misses          8        8           
Impacted Files Coverage Δ
src/service/botHandler.js 100.00% <100.00%> (ø)
src/service/customObjectHandler.js 100.00% <100.00%> (ø)
src/service/inFolderHandler.js 100.00% <100.00%> (ø)
src/service/inResourceHandler.js 100.00% <100.00%> (ø)
src/service/subCustomObjectHandler.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4da80a6...16f6adc. Read the comment docs.

@scolladon scolladon marked this pull request as ready for review March 16, 2022 15:14
@scolladon scolladon enabled auto-merge (squash) March 16, 2022 15:15
@codeclimate
Copy link

codeclimate bot commented Mar 16, 2022

Code Climate has analyzed commit 16f6adc and detected 0 issues on this pull request.

View more on Code Climate.

Copy link
Collaborator

@mehdicherf mehdicherf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@scolladon scolladon merged commit 5aa12c1 into main Mar 16, 2022
@scolladon scolladon deleted the fix/masterdetail-customobject branch March 16, 2022 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When custom object metadata changes, master detail field is not copied to output
2 participants