Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow 'tag' type git pointer #283

Merged
merged 4 commits into from
Mar 31, 2022
Merged

fix: allow 'tag' type git pointer #283

merged 4 commits into from
Mar 31, 2022

Conversation

scolladon
Copy link
Owner

What does this pull request contain?


  • Added (for new features).
  • Changed (for changes in existing functionality).
  • Deprecated (for soon-to-be removed features).
  • Removed (for now removed features).
  • Fixed (for any bug fixes).
  • Security (for vulnerability fixes).

Explain your changes


It allow tag git pointer to be reference in the --to and --from parameters

Does this close any currently open issues?


closes #282

  • Jest test added to check the fix is applied.

@scolladon scolladon enabled auto-merge (squash) March 31, 2022 16:45
@codecov
Copy link

codecov bot commented Mar 31, 2022

Codecov Report

Merging #283 (71fc658) into main (00ceeb8) will not change coverage.
The diff coverage is 100.00%.

❗ Current head 71fc658 differs from pull request most recent head f37d870. Consider uploading reports for the commit f37d870 to get more accurate results

@@            Coverage Diff            @@
##              main      #283   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           22        22           
  Lines          621       625    +4     
=========================================
+ Hits           621       625    +4     
Impacted Files Coverage Δ
src/utils/cliHelper.js 100.00% <100.00%> (ø)
src/utils/gitConstants.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 00ceeb8...f37d870. Read the comment docs.

Copy link
Owner Author

@scolladon scolladon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codeclimate
Copy link

codeclimate bot commented Mar 31, 2022

Code Climate has analyzed commit f37d870 and detected 0 issues on this pull request.

View more on Code Climate.

@scolladon scolladon disabled auto-merge March 31, 2022 21:23
@scolladon scolladon merged commit 183fb4f into main Mar 31, 2022
@scolladon scolladon deleted the fix/git-pointer-check branch March 31, 2022 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"error": "--from is not a valid sha pointer: 'DEV'",
1 participant