Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: prepare i18n #287

Merged
merged 4 commits into from
Apr 21, 2022
Merged

feat: prepare i18n #287

merged 4 commits into from
Apr 21, 2022

Conversation

scolladon
Copy link
Owner

What does this pull request contain?


  • Added (for new features).
  • Changed (for changes in existing functionality).
  • Deprecated (for soon-to-be removed features).
  • Removed (for now removed features).
  • Fixed (for any bug fixes).
  • Security (for vulnerability fixes).

Explain your changes


Export error message to a dedicated file
Prepare for i18n

@codecov
Copy link

codecov bot commented Apr 10, 2022

Codecov Report

Merging #287 (d673612) into main (9a038db) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main      #287   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           22        23    +1     
  Lines          628       634    +6     
=========================================
+ Hits           628       634    +6     
Impacted Files Coverage Δ
src/locales/en.js 100.00% <100.00%> (ø)
src/utils/cliHelper.js 100.00% <100.00%> (ø)
src/utils/repoSetup.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9a038db...d673612. Read the comment docs.

@scolladon scolladon force-pushed the feat/formatted-error-communication branch from 8b9f293 to d673612 Compare April 19, 2022 11:04
@codeclimate
Copy link

codeclimate bot commented Apr 19, 2022

Code Climate has analyzed commit d673612 and detected 0 issues on this pull request.

View more on Code Climate.

Copy link
Collaborator

@mehdicherf mehdicherf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@scolladon scolladon merged commit 001c07e into main Apr 21, 2022
@scolladon scolladon deleted the feat/formatted-error-communication branch April 21, 2022 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants