-
-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add conditional deployment use case to readme #289
docs: add conditional deployment use case to readme #289
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks for this addition
Codecov Report
@@ Coverage Diff @@
## main #289 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 22 22
Lines 628 628
=========================================
Hits 628 628 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few changes we can discuss.
Thanks for the work so far, I think it is very helpful
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you Thomas!
In addition to @scolladon comments, I would add 2 things:
- Add the new section to the Table of Contents
- I would put it before the U_se the module in your own node application_ section (that last section is for very specific use-cases, and should remain at the bottom, IMO).
Co-authored-by: Sebastien <[email protected]>
Co-authored-by: Sebastien <[email protected]>
@tprouvot I can help on the Table of Content generation, we use a tool to do that automatically, give me access to your repo and I'll contribute |
Code Climate has analyzed commit 13480a7 and detected 0 issues on this pull request. View more on Code Climate. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Thank you Thomas!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Hi @scolladon I should have accepted your proposition because I tested the table of content on the new entry and it doesn't redirect to the section... I found the issue on the link and fixed it on my repo. Would you like me to create another PR ? |
@tprouvot that's a good idea, yes please create another PR (fix type) |
What does this pull request contain?
Add conditional deplyment use case in the README, as a solution to solve deployment errors when delta files are empty.
Does this close any currently open issues?
closes #249