Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: silent flag parameter #415

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

gavignon
Copy link
Contributor

@gavignon gavignon commented Jan 9, 2023

What does this pull request contain?

Silent Flag to clean the output when --json parameter is not set and the command executed successfully

Does this close any currently open issues?

Resolves #378

@scolladon scolladon changed the title Silent Flag Feature feat: silent flag parameter Jan 9, 2023
@codecov
Copy link

codecov bot commented Jan 9, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (3484e31) 100.00% compared to head (a0208cd) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #415   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           32        32           
  Lines          898       898           
=========================================
  Hits           898       898           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Owner

@scolladon scolladon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I ask for a few changes (we can discuss them if you think otherwise)

I think we could add 2 test in cli.test.js to cover this new cli behavior

Look forward to read the next iteration, so far so good !

CONTRIBUTING.md Show resolved Hide resolved
messages/delta.js Outdated Show resolved Hide resolved
src/commands/sgd/source/delta.ts Show resolved Hide resolved
src/commands/sgd/source/delta.ts Outdated Show resolved Hide resolved
@codeclimate
Copy link

codeclimate bot commented May 22, 2023

Code Climate has analyzed commit a0208cd and detected 0 issues on this pull request.

View more on Code Climate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clean output if json parameter is not set
2 participants