-
-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: readDir git based implementation #419
Conversation
Code Climate has analyzed commit fa144a2 and detected 0 issues on this pull request. View more on Code Climate. |
Codecov ReportBase: 100.00% // Head: 100.00% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## main #419 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 31 31
Lines 815 814 -1
=========================================
- Hits 815 814 -1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
What does this pull request contain?
Explain your changes
Fix home made git based
readDir
implementation and usagefs.readdir
returns afs.Dirent
data structure which tell us if the element is a folder or a file.Using git to explore folder content returns string.
A element is a folder if it ends with '/'
Some part of the code relied on not having this slash at the end of a file.
Fix config parameter in
fsHelper
Improve error handling in
fsHelper
Does this close any currently open issues?
closes #413
closes #414
closes #416
Any particular element that can be tested locally
Build a lwc component with subfolder (for test for example), modify the js file, check all the content of the module (even sub folder) is copied to output
This playground can be used as well
This branch in our playground can be used as well
Any other comments