Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add v59 metadata definition #698

Merged
merged 3 commits into from
Sep 26, 2023
Merged

feat: add v59 metadata definition #698

merged 3 commits into from
Sep 26, 2023

Conversation

scolladon
Copy link
Owner

Explain your changes


Add the metadata definition for v59
Change the logic to take the default latest supported version. It is now the second last
=> This will allow us support new version during preview period.

Does this close any currently open issues?


closes #696

  • Jest tests added to cover the fix.
  • NUT tests added to cover the fix.
  • E2E tests added to cover the fix.

@codeclimate
Copy link

codeclimate bot commented Sep 26, 2023

Code Climate has analyzed commit dd39530 and detected 0 issues on this pull request.

View more on Code Climate.

@codecov
Copy link

codecov bot commented Sep 26, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (443034b) 100.00% compared to head (dd39530) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #698   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           33        33           
  Lines          952       957    +5     
  Branches        96        96           
=========================================
+ Hits           952       957    +5     
Files Coverage Δ
src/metadata/metadataManager.ts 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@scolladon scolladon merged commit 91966d5 into main Sep 26, 2023
23 of 24 checks passed
@scolladon scolladon deleted the feat/v59-support branch September 26, 2023 15:39
@github-actions
Copy link

Shipped in release v5.26.0.
You can install the new version using the version number or the latest-rc channel

$ sfdx plugins:install sfdx-git-delta@latest-rc
$ sfdx plugins:install [email protected]

Happy incremental deployment!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error - "API version not found or not supported, using '58' instead"
2 participants