-
-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: adding prediction builder ai metadata types #731
feat: adding prediction builder ai metadata types #731
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Nice addition, thank you.
I checked API version, xml names, directory, suffix and other particularities and it seems fine !
Could you just add those metadata definitions at the beginning of the file please @gaviriajesus ? The end of the file is used for other special metadata currently
On it. |
Code Climate has analyzed commit 9a3120e and detected 0 issues on this pull request. View more on Code Climate. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
#Done |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #731 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 35 35
Lines 988 988
Branches 97 97
=========================================
Hits 988 988 ☔ View full report in Codecov by Sentry. |
Shipped in release $ sfdx plugins:install sfdx-git-delta@latest-rc
$ sfdx plugins:install [email protected] Happy incremental deployment! |
Explain your changes
Adding 4 metadata types to the different metadata files to allow Einstein Prediction Builder delta deployments.
Does this close any currently open issues?
No Issue related to this.
Any particular element that can be tested locally
Any other comments
an AI Model was created and deployed through VS Code with these files and it works so deltas will work as well, the
directoryName, suffix and xmlName were triple checked with a local example.
inFolder and metaFile where set to false as I copied the connectedApps one.