Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adding prediction builder ai metadata types #731

Merged

Conversation

gaviriajesus
Copy link
Contributor

Explain your changes

Adding 4 metadata types to the different metadata files to allow Einstein Prediction Builder delta deployments.

Does this close any currently open issues?


No Issue related to this.

Any particular element that can be tested locally


Any other comments

an AI Model was created and deployed through VS Code with these files and it works so deltas will work as well, the

directoryName, suffix and xmlName were triple checked with a local example.
inFolder and metaFile where set to false as I copied the connectedApps one.

Copy link
Owner

@scolladon scolladon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Nice addition, thank you.
I checked API version, xml names, directory, suffix and other particularities and it seems fine !

Could you just add those metadata definitions at the beginning of the file please @gaviriajesus ? The end of the file is used for other special metadata currently

@gaviriajesus
Copy link
Contributor Author

LGTM

Nice addition, thank you. I checked API version, xml names, directory, suffix and other particularities and it seems fine !

Could you just add those metadata definitions at the beginning of the file please @gaviriajesus ? The end of the file is used for other special metadata currently

On it.

Copy link

codeclimate bot commented Dec 4, 2023

Code Climate has analyzed commit 9a3120e and detected 0 issues on this pull request.

View more on Code Climate.

Copy link
Owner

@scolladon scolladon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gaviriajesus
Copy link
Contributor Author

LGTM

Nice addition, thank you. I checked API version, xml names, directory, suffix and other particularities and it seems fine !

Could you just add those metadata definitions at the beginning of the file please @gaviriajesus ? The end of the file is used for other special metadata currently

#Done
My pleasure, looking forward to collaborating more. Added metadata definitions at the beginning of the files

Copy link

codecov bot commented Dec 4, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (50f03da) 100.00% compared to head (9a3120e) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #731   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           35        35           
  Lines          988       988           
  Branches        97        97           
=========================================
  Hits           988       988           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@scolladon scolladon merged commit b830a8f into scolladon:main Dec 5, 2023
20 of 22 checks passed
Copy link

github-actions bot commented Dec 8, 2023

Shipped in release v5.31.0.
You can install the new version using the version number or the latest-rc channel

$ sfdx plugins:install sfdx-git-delta@latest-rc
$ sfdx plugins:install [email protected]

Happy incremental deployment!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants