feat: warn when a flow is deleted

[scolladon]

Explain your changes

---

Add a warning in the output of SGD when the plugin detect a deletion of a flow

Does this close any currently open issues?

---

closes #893

• Jest tests added to cover the fix.

Any particular element that can be tested locally

---

Any other comments

---

[scolladon]

Please help reviewing here @amtrack :)

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (f79d3dc) to head (39d040f).

Additional details and impacted files

@@            Coverage Diff            @@
##              main      #894   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           39        40    +1     
  Lines         1066      1074    +8     
  Branches       115       115           
=========================================
+ Hits          1066      1074    +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[amtrack]

@scolladon I've just tested deploying the Flow with Status=Draft and Status=Obsolete and it didn't disable the Flow in my org.

This is also described here: #588 (comment)

In my opinion the second way would be be actually an addition to the first way:

What I have tested is, that you can disable the Flow using the FlowDefinition activeVersionNumber=0 and delete inactive Flow Versions in a single deployment (here v1 and v2) using a destructiveChanges.xml like:

Set_Account_Description.flowDefinition-meta.xml:

<?xml version="1.0" encoding="UTF-8"?>
<FlowDefinition xmlns="http://soap.sforce.com/2006/04/metadata">
    <activeVersionNumber>0</activeVersionNumber>
</FlowDefinition>

package.xml:

<?xml version="1.0" encoding="UTF-8"?>
<Package xmlns="http://soap.sforce.com/2006/04/metadata">
    <types>
        <members>Set_Account_Description</members>
        <name>FlowDefinition</name>
    </types>
    <version>61.0</version>
</Package>

destructiveChanges.xml:

<?xml version="1.0" encoding="UTF-8"?>
<Package xmlns="http://soap.sforce.com/2006/04/metadata">
    <types>
        <members>Set_Account_Description-1</members>
        <members>Set_Account_Description-2</members>
        <name>Flow</name>
    </types>
    <version>61.0</version>
</Package>

[scolladon]

That's great combo, it could be the way to delete a flow with one go (until the v44 is decomissionated and FlowDefinition metadata is not available anymore).

The issue I see is it requires to know which flow versions to list in the destructiveChanges.xml... Which can be a complicated things to determine for SGD because it could not be the same in different environments and the plugin is not connected to any environment.

So I think it should not be handled by SGD.
It could be automatized by another plugin dedicated to deleting flow.

I'll update the documentation in the PR with your solution, thx

[scolladon]

suggestion: do you think you could deal with this automation inside sfdx-hardis

I think it could be wrap behind a command like sf hardis org delete flow -n <FLOW_API_NAME>, what do you think @nvuillam ?

[scolladon]

Hi @amtrack !

We have updated the warning message and the readme, what do you think now ?

[amtrack]

@scolladon Thanks! Looks good to me! I've only suggested to correct destructiveChanges.xml to destructiveChangesPost.xml.

[codeclimate]

Code Climate has analyzed commit 39d040f and detected 0 issues on this pull request.

View more on Code Climate.

[github-actions]

Shipped in release v5.41.0.
You can install the new version using the version number or the latest-rc channel

$ sfdx plugins:install sfdx-git-delta@latest-rc
$ sfdx plugins:install [email protected]

Happy incremental deployment!