Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add FeatureParameter metadata support #915

Merged

Conversation

aljaz823
Copy link
Contributor

Explain your changes


Add metadata support for all three types of Feature Parameters:

Copy link
Owner

@scolladon scolladon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice addition, thanks !!!

Could the definition be at the top of the file ?
Also, has it been tested manually ?

Copy link

codecov bot commented Sep 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (5562561) to head (7675772).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #915   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           40        40           
  Lines         1083      1083           
  Branches       115       115           
=========================================
  Hits          1083      1083           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aljaz823 aljaz823 force-pushed the feature/support-feature-parameters-metadata branch from ed6f70f to ead7929 Compare September 12, 2024 13:35
@aljaz823
Copy link
Contributor Author

aljaz823 commented Sep 12, 2024

Nice addition, thanks !!!

Could the definition be at the top of the file ? Also, has it been tested manually ?

Sure, I moved definitions to the top of metadata files.

It has been tested manually, here is the result.

Feature parameters of all three different types:

image

Generated diff package.xml file:

<?xml version="1.0" encoding="UTF-8"?>
<Package xmlns="http://soap.sforce.com/2006/04/metadata">
    <types>
        <members>FeatureBoolean1</members>
        <name>FeatureParameterBoolean</name>
    </types>
    <types>
        <members>FeatureDate1</members>
        <name>FeatureParameterDate</name>
    </types>
    <types>
        <members>FeatureSet1</members>
        <members>FeatureSet2</members>
        <name>FeatureParameterInteger</name>
    </types>
    <version>60.0</version>
</Package>

Copy link
Owner

@scolladon scolladon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for putting the definition on top of the file.
The bottom is reserved to certain types I prefer to be grouped.

Could you add an integration test for those types please ?
You just have to add an item in the list for each new type.
If you struggle with that I can add it, just let me know
As they are regrouped in the same folder I would like to couple the test with the metadata definition, just to fix the spec explicitely

@aljaz823 aljaz823 force-pushed the feature/support-feature-parameters-metadata branch from ead7929 to 7675772 Compare September 12, 2024 14:55
Copy link

codeclimate bot commented Sep 12, 2024

Code Climate has analyzed commit 7675772 and detected 0 issues on this pull request.

View more on Code Climate.

@aljaz823
Copy link
Contributor Author

aljaz823 commented Sep 12, 2024

I added the integration tests, though I'm not familiar with that so I just followed the other patterns. Let me know if it needs additional fixing.

Copy link
Owner

@scolladon scolladon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Great job, thanks for this contribution

@scolladon scolladon mentioned this pull request Sep 13, 2024
@scolladon scolladon merged commit f3c9ca2 into scolladon:main Sep 13, 2024
20 of 29 checks passed
@aljaz823 aljaz823 deleted the feature/support-feature-parameters-metadata branch September 13, 2024 10:02
Copy link

Shipped in release v5.44.0.
You can install the new version using the version number or the latest-rc channel

$ sfdx plugins:install sfdx-git-delta@latest-rc
$ sfdx plugins:install [email protected]

Happy incremental deployment!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants