Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow the user to delete the default image. #90

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

marcosschroh
Copy link

When the plugin is initialized, it has an option to load a default image. if the user wanted to delete the image and upload a new one it was impossible because the preview image will be loaded again, so with this new option, the user can delete the default image, and if he want to restore it, he can clicking in the "Reset Button".

@Ben305
Copy link

Ben305 commented Apr 14, 2015

+1

1 similar comment
@drd00m
Copy link

drd00m commented Apr 14, 2015

+1

@sconsult
Copy link
Owner

Hi @marcosschroh ,

Just got around to check into the pull requests. You have some good points, i will test your code and will merge it with the master if everything works as described.

Thank you for the effort

Mat

@marcosschroh
Copy link
Author

Hi, I just want to know if you can check the code. I have added an extra option to set a custom 'Crop button', similar to 'Custom upload button'. You can test this new feature if you want

@txofox
Copy link

txofox commented Sep 4, 2015

Hi, I would like to know if the code for Reset button is checked and when it will be merged with master code?

@sconsult
Copy link
Owner

sconsult commented Sep 4, 2015

Hi @txofox

Our team will take a look at the implementation if time permits, however the code was not submitted properly and resulted in a 7241 line changes, meaning somebody has to examine the code.

Not that i don't appreciate the effort marcoschroh put in.

As of right now we leave it as a reference but have no resources to check or reintegrate the code.

No

Cheers

Mat

@alpaltunel
Copy link

what is the status of this pullrequest? I exactly need this function. If you use loadImage option then its impossible to change it. I need to change image. but how?

@marcosschroh
Copy link
Author

Hi @alpaltunel,

You can see the the example in my repo. It's working good.

@sconsult If you want I can to do a new pull request and try to avoid to change a lot of lines.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants