Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alignment Indicators #111

Merged
merged 13 commits into from
Dec 22, 2020
Merged

Commits on Dec 21, 2020

  1. CAD: Add shapes.scad

    Includes modules for rounded squares and triangles
    dmadison committed Dec 21, 2020
    Configuration menu
    Copy the full SHA
    0dd979f View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    bbb2daf View commit details
    Browse the repository at this point in the history
  3. CAD: Remove equilateral centering for triangles

    This is clever in principle but poor in practice, because you have to assume the intention behind the centering command. Do you want to center based on the size (bounding box), or do you want to center based on the rotation if the triangle is equilateral? Easier to always assume bounding box centering and get rid of the trig.
    dmadison committed Dec 21, 2020
    Configuration menu
    Copy the full SHA
    5505042 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    8b951f9 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    5f29dab View commit details
    Browse the repository at this point in the history
  6. CAD: Use a single etch depth value

    Previously this was split between a hard "0.1" for the etch style module and a separate "0.1" for the spool etching. This unifies both as a single value.
    dmadison committed Dec 21, 2020
    Configuration menu
    Copy the full SHA
    c6f2143 View commit details
    Browse the repository at this point in the history
  7. CAD: Simplify spool etching placement

    Uses the enclosure_etch_style() helper function to simplify placement. Also removes the 3D difference() function to simplify rendering.
    dmadison committed Dec 21, 2020
    Configuration menu
    Copy the full SHA
    c5ef875 View commit details
    Browse the repository at this point in the history
  8. CAD: Swap indicator shapes

    Using a triangle for the motor/left side and a circle for the idler/right side. The triangle requires less etching area than the square and should provide more contrast with the circle at smaller sizes / lower etching resolutions.
    dmadison committed Dec 21, 2020
    Configuration menu
    Copy the full SHA
    6095513 View commit details
    Browse the repository at this point in the history

Commits on Dec 22, 2020

  1. Configuration menu
    Copy the full SHA
    71fcfb8 View commit details
    Browse the repository at this point in the history
  2. CAD: Fix right alignment indicator Y calculation

    This should use the pre-calculated "enclosure_indicator_position_y" value along with all of the other etched indicators.
    dmadison committed Dec 22, 2020
    Configuration menu
    Copy the full SHA
    f11256a View commit details
    Browse the repository at this point in the history
  3. CAD: Add alignment indicators to both ends

    Visually, the symmetry looks better.
    dmadison committed Dec 22, 2020
    Configuration menu
    Copy the full SHA
    9e60870 View commit details
    Browse the repository at this point in the history
  4. Revert "CAD: Add alignment indicators to both ends"

    Although this looks better it's significantly more expensive to produce: the single-ended etched indicators add about $0.56 to the cost per enclosure @ Ponoko. The dual-ended etched indicators add $4.51, presumably because of the travel time between aligned indicators in the rasterized version.
    
    This reverts commit 9e60870.
    dmadison committed Dec 22, 2020
    Configuration menu
    Copy the full SHA
    78fe976 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    fc36c57 View commit details
    Browse the repository at this point in the history