Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Python example (and v2 character set) for new features #242

Merged
merged 4 commits into from
Oct 5, 2024
Merged

Update Python example (and v2 character set) for new features #242

merged 4 commits into from
Oct 5, 2024

Conversation

shamlian
Copy link
Contributor

@shamlian shamlian commented Sep 1, 2024 •
edited
Loading

  • Replaced ~ with @ in default v2 character set to match shipped flaps
  • Get character set from splitflap display (if possible, otherwise use previous legacy alphabet)
  • Use upper case in demo words to match new character sets

@shamlian shamlian changed the title Fix python example (and v2 character set) Update Python example (and v2 character set) for new features Sep 1, 2024
shamlian
shamlian commented Sep 1, 2024
View reviewed changes
software/chainlink/splitflap_proto.py
'.',
',',
'\'',
_LEGACY_ALPHABET = [
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I changed this based on the webserial example.

scottbez1
scottbez1 approved these changes Oct 5, 2024
View reviewed changes
Copy link
Owner

@scottbez1 scottbez1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks for the PR!

@scottbez1 scottbez1 merged commit edee41a into scottbez1:master Oct 5, 2024
@shamlian shamlian deleted the fix_python_example branch October 19, 2024 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scottbez1 scottbez1 scottbez1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shamlian @scottbez1