-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
No newlines printed when output is not a terminal #77
Comments
Good catch, and good troubleshooting. You made this easy to recreate which was key to fixing the issue. I believe I landed the fix in ddf641f. Can you please test that and let me know if that solves your problem? It's worth noting that |
Thank you for quick response, this change from ddf641f fixed output when output is not a terminal but a "cat":
And yes, With ssh it also works fine, 1 line per second for default mode. I also tested this is clustershell "clush": PS One more minor difference from vmstat. Vmstat outputs one line with end of line \n, and then waits for interval. When I press Ctrl-C using ssh for remote run, cursor position is column 0. With dool, cursor is positioned at the end of line, and no \n printed immediately. When I press Ctrl-C, my original shell prints its prompt to the right of last line, not in newline.
|
Interesting... I learned something about Also worth noting we have |
SUMMARY
I want to run dool over ssh on remote nodes. But when output is not a terminal, no newline is printed
ISSUE TYPE
DOOL VERSION
Dool 1.3.3
OS / ENVIRONMENT
Linux Ubuntu 22.04
STEPS TO REPRODUCE
./dool-orig/dool |cat
It should be like normal dool, only without color; with newlines. (some remote ssh-like tools only flush on newline)
EXPECTED RESULTS
ACTUAL RESULTS
The text was updated successfully, but these errors were encountered: