fix(kitty.conf): base16 correction on brights (color8) #110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If color0 and color8 are the same, the zsh-autosuggestions are the same colour as the background making it difficult to read. I used the wezterm config as reference and found that the color8 used in this config was incorrect thus fixed.
|
Before correction:
After correction: |
scottmckendry
requested changes
Aug 3, 2024
There was a problem hiding this comment.
Good spotting! Thanks for raising the PR with the fix.
The only problem is that the change has been made directly on the .conf file. This will get automatically overwritten when it's merged.
You'll want to edit the template here:
https://github.com/scottmckendry/cyberdream.nvim/blob/main/lua/cyberdream/extra/kitty.lua
More info on extras can be found in the contributing guide below:
https://github.com/scottmckendry/cyberdream.nvim/blob/main/CONTRIBUTING.md#adding-extras-
|
That's my bad, i will push a new commit with these changes |
Edited kitty.lua so that it won't overwrite the .conf file.
scottmckendry
approved these changes
Aug 3, 2024
|
LGTM! Thanks @juniorsundar-tii 🙂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If color0 and color8 are the same, the zsh-autosuggestions are the same colour as the background making it difficult to read.
I used the wezterm config as reference and found that the color8 used in this config was incorrect thus fixed.