How about to have status values of "empty" or "not empty" of the icem… #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…aker tank entity? This is just a (weak) proposal, since the current value of "enabled/disabled" is not intuitive (I think).
|
Yes, this is better! thanks! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How about to have status values of "empty" or "not empty" of the icemaker tank entity?
This is just a (weak) proposal, since the current value of "enabled/disabled" is not intuitive (I think).
P.S.
I am slightly disappointed about the usage of the fridge via echonet (not blaming you at all...). There is no room of automation, except the notification of icemaker tank. This PR is just for my automation.
P.P.S.
This PR is not tested at all. I do not know how echonetlite_homeassistant loads the pychonet lib. Additionally, I am stuck at loading newer echonetlite_homeassistant due to the "integration is already in the store" error when trying to load new one.