Support multiple source roots in report generators (issue #104) #109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Seq[File]) as input parameter.
…urce root matches), this means there are some configuration problems and failing fast is better solution than generating inproper file paths (causing IOExceptions later).
… <sources> section.
…XmlReportWriter).
| ) | ||
| sourceRoot match { | ||
| case Some(path: String) => src.replace(path, "") | ||
| case _ => throw new RuntimeException(s"No source root found for '$src'"); //TODO Change exception class |
There was a problem hiding this comment.
I didn't want to decide what exception will be the best :)
There was a problem hiding this comment.
Maybe IllegalArgumentException? Method contract states src must have at least one source root in given sourcePaths.
|
Reviewed, aside from minor nitpicks LGTM. |
This was referenced Mar 3, 2015
|
I forgot to fix tests. |
This was referenced Mar 9, 2015
gslowikowski
added a commit
that referenced
this pull request
Mar 12, 2015
Support multiple source roots in report generators (issue #104)
|
Merged manually - db86022 |
gslowikowski
added a commit
that referenced
this pull request
Mar 28, 2015
… specified path, shows all source root paths for easier problems detection.
gslowikowski
added a commit
to gslowikowski/scalac-scoverage-plugin
that referenced
this pull request
Mar 28, 2015
…se class created and common code moved there. "IOUtils.relativeSource" moved there too, because it's reports specific and works on paths as strings, not real files.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR for #104