Fix NPE during report aggregation when multiple modules are specified using -pl arg #104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @gslowikowski, could you please review this PR? |
|
Gentle ping @gslowikowski :) |
|
Hi @sumeetgajjar |
jozic
force-pushed
the
aggregate-report-NPE-fix
branch
from
8ffeb12
to
e7b749c
Compare
jozic
force-pushed
the
aggregate-report-NPE-fix
branch
from
6767c3b
to
ccbd8d0
Compare
jozic
approved these changes
Dec 28, 2023
There was a problem hiding this comment.
@sumeetgajjar
I've added the test myself. It was failing without your changes, and is passing with the changes.
Thank you for your contribution!
|
Hi @jozic, I am travelling as of now thus my responses are delayed. Thanks for rebasing the changes and adding the integration tests 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #103
What changes were proposed in this pull request?
This PR proposes to set
topLevelModulevariable to the current execution root whentopLevelModuleis null.We achieve this by traversing upwards in the maven module hierarchy unless we find a module that returns
trueformodule.isExecutionRoot().After this fix, the aggregated report will be available in the current execution root matching the execution behavior of the when
-plis not specified.Why are the changes needed?
When report aggregation is run against multiple modules are specified using -pl arg,
topLevelModuleis never set to a non-null value since non of the reactor projects return true formodule.isExecutionRoot().How was this patch tested?
Tested the patch manually on the example mentioned in #103