test: fix flaky test-cluster-shared-leak

Wait for worker2 to come online before doing anything that might result in an EPIPE. Fixes flakiness of test on Windows. Fixes: nodejs#3956 PR-URL: nodejs#4510 Reviewed-By: Johan Bergström <[email protected]> Reviewed-By: James M Snell<[email protected]>
scovetta · Apr 2, 2016 · cf3c3bf · cf3c3bf
1 parent 966c110
commit cf3c3bf
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 9 deletions.
diff --git a/test/parallel/parallel.status b/test/parallel/parallel.status
@@ -7,7 +7,6 @@ prefix parallel
 [true] # This section applies to all platforms
 
 [$system==win32]
-test-cluster-shared-leak             : PASS,FLAKY
 test-debug-no-context                : PASS,FLAKY
 test-tls-ticket-cluster              : PASS,FLAKY
 

diff --git a/test/parallel/test-cluster-shared-leak.js b/test/parallel/test-cluster-shared-leak.js
@@ -15,14 +15,16 @@ if (cluster.isMaster) {
   worker1 = cluster.fork();
   worker1.on('message', common.mustCall(function() {
     worker2 = cluster.fork();
-    conn = net.connect(common.PORT, common.mustCall(function() {
-      worker1.send('die');
-      worker2.send('die');
-    }));
-    conn.on('error', function(e) {
-      // ECONNRESET is OK
-      if (e.code !== 'ECONNRESET')
-        throw e;
+    worker2.on('online', function() {
+      conn = net.connect(common.PORT, common.mustCall(function() {
+        worker1.send('die');
+        worker2.send('die');
+      }));
+      conn.on('error', function(e) {
+        // ECONNRESET is OK
+        if (e.code !== 'ECONNRESET')
+          throw e;
+      });
     });
   }));