add tox config to test Python 3.5 to 3.8 #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It seems this is the best approach to have different python versions: https://ben.fogbutter.com/2016/02/20/testing-multiple-python-versions-on-circleci.html |
BurnzZ
force-pushed
the
add-tox
branch
6 times, most recently
from
c31b319
to
3b82544
Compare
Complete work to support multiple versions of Python in CI
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@akshayphilar I'm adding some tox configs since we need to ensure that the new functionalities we will be implementing in https://github.com/scrapinghub/shublang/issues?q=is%3Aissue+is%3Aopen+label%3A%22good+first+issue%22 correctly runs across different Python 3 versions.
@jsargiot, I'm quite unfamiliar with CircleCI as SH uses Travis CI in majority of its repos. Could you review if I'm invoking
toxcorrectly?For Travis CI, we usually configure it via https://github.com/scrapy/itemloaders/blob/master/.travis.yml#L8-L23 which results in https://travis-ci.com/github/scrapy/itemloaders/builds/178576103, testing across the declared Python environments.
EDIT: Looks like the new tox config correctly runs in Circle CI as can be seen in this build. However, it would seem that some of the Python envs are not setup yet in it.
Thanks!