Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added support for urlparse functions #63

Merged
merged 2 commits into from
Oct 5, 2020
Merged

Added support for urlparse functions #63

merged 2 commits into from
Oct 5, 2020

Conversation

sagararora19992
Copy link
Contributor

No description provided.

VMRuiz
VMRuiz requested changes Sep 29, 2020
View reviewed changes
Copy link

@VMRuiz VMRuiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello Sagar,

Maybe you can add an additional method that just return all the urlparse info as a dictionary? It would be more flexible than this approach.

Also, please add unit tests.

@sagararora19992
Copy link
Contributor Author

@VMRuiz All changes are completed.

VMRuiz
VMRuiz approved these changes Oct 4, 2020
View reviewed changes
Copy link

@VMRuiz VMRuiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@VMRuiz VMRuiz requested a review from Gallaecio October 4, 2020 09:05
@VMRuiz
Copy link

VMRuiz commented Oct 5, 2020

Implements #56

@sagararora19992 sagararora19992 merged commit 672b95b into master Oct 5, 2020
@sagararora19992 sagararora19992 deleted the urlparse-support branch October 5, 2020 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VMRuiz VMRuiz VMRuiz approved these changes

@akshayphilar akshayphilar Awaiting requested review from akshayphilar

@Gallaecio Gallaecio Awaiting requested review from Gallaecio

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sagararora19992 @VMRuiz