-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CSS Selectors Level 4 Support #108
Comments
Hi Gallaecio! I would like to work on this project,I already have Worked on CSS Selectors level |
Hi, i would also like to work on this project |
I believe the deadline to present a proposal ends in less than 24h, and sending a pre-application pull request so that we can see how you work is a requirement, so the timeline is rather tight. See http://gsoc2020.scrapinghub.com/participate for details. |
Hello, @Gallaecio ! I'm also interested in contributing to this project as part Google Summer of Code 2021, but the aim and expected result seems a little vague. On the list of open issues you linked above there is one issue with last update in 2016 and one issue with closed pr attached, though the issue itself is still open. |
At the moment, There are issues that are quite old because this feature was initially requested a long time ago. It is still relevant, though. As for #66, I see no closed pull request linked; there’s an open one, #96, which once merged will only fix a part of #66. |
@Gallaecio , thanks for your reply |
Your proposal lists issues and features to implement, but I think it would be great if you could go into more detail about your plan for each of them. For example, it would be great if you could detail how you plan to translate each CSS Selector Level 4 feature that you plan to add to XPath 1.0, i.e. provide examples of the corresponding CSS Selector Level 4 features, and the matching XPath 1.0 expressions that you want to get Also, just assuming that each issue will take 1 week may be overly optimistic. It would be best for you to look into each issue and really estimate how much you think each will take. It may even make sense to split work on some of them into different parts. It’s important to make some initial research now so that your project timeline is as accurate as possible, and pessimistic when in doubt, to make sure your project is successful. |
Thank you for review. I added details and made timeline less optimistic as you suggested. |
What specifically do you plan to implement that is not already implemented in #96? Also, stretch goals make sense, but they should not be a part of the timeline. For example, if nesting support is meant as a stretch goal, to be done only if time allows, then it should not be a part of this week’s work. You can propose stretch goals after the timeline, in a separate section.
I think this is something that needs to be done now, not as part of the project, as it is part of defining the scope of the project itself. About priorities, I have no preference, so I suggest you go with the stuff that you find more achievable, or more interesting for you personally. |
Thanks for getting back to me so quickly :)
As far as I understand,
Moved all
Nice thought. I've already listed some differences, so I'll choose a couple of likely achievable. |
Nice job, it’s looking much better.
Given the meaning of As to how your example expression should be interpreted, I’m not sure either 😅 . I imagine that it’s either as “a dt containing something that is immediately followed by a sibling dt”, or “a dt that is itself immediately followed by a sibling dt”.
Could you elaborate on what parts of the issue seem vague, or what aspects may be hard or impossible to implement? I may be misreading or missing something, but the
I’ve just read about That said, I see no reason not to support it, even if it is just for the sake of completion. Finally, in addition to describing the work that you plan to achieve as part of this project, and your stretch goals, it would be good to describe the parts of CSS Selectors Level 4 that will not be a part of your project or stretch goals, and why. I imagine some elements simply make no sense for |
Yeah, absolutely right. I just accidentally looked at the neighbouring line in the docs and made a translation for
Well, the first example is already implemented and works just fine:
but the second one is not a simple selector, so it's harder to implement, though I found a translation
It won't be nice if someone catches
Added section "Not a part of this project" to proposal |
Well, I have no further feedback; the proposal looks good to me, and you seem to understand the problem pretty well. You also have submitted the required PR (please mention it in the proposal). So now just make sure you meet the Google deadlines to submit the proposal on their platform, and let me know if there is anything else I can help you with. |
Thank you a lot :) |
We have a few issues open about adding support for specific parts of the CSS Selectors Level 4 specification already. The aim, however, is to eventually reach complete support.
The text was updated successfully, but these errors were encountered: