New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ID selector syntax #114

Open

annbgn wants to merge 1 commit into scrapy:master from annbgn:fix_id_selector_syntax

Contributor

annbgn commented Apr 6, 2021 •

edited

Loading

In issue #24 it is mentioned that https://www.w3.org/TR/CSS21/syndata.html#value-def-identifier says:

cannot start with a digit, two hyphens, or a hyphen followed by a digit

this pr adds validation for the 3 cases mentioned and raises error. tests are also extended.


          Fix ID selector syntax

7fdc02c

Gallaecio mentioned this pull request

CSS Selectors Level 4 Support #108

Open

Member

Gallaecio commented Apr 20, 2021

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet