Support complex selector in not #124
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Eugenio Lacuesta <[email protected]>
…lect into add_support_for_has
…lect into add_support_for_has
…_translation_change Revert xpath translation change to make it consistent
annbgn
force-pushed
the
support_complex_selector_in_not
branch
from
d02d89b
to
2c15198
Compare
Codecov Report
@@ Coverage Diff @@
## master #124 +/- ##
==========================================
+ Coverage 95.39% 96.01% +0.62%
==========================================
Files 3 3
Lines 803 904 +101
Branches 139 150 +11
==========================================
+ Hits 766 868 +102
+ Misses 20 19 -1
Partials 17 17
Continue to review full report at Codecov.
|
annbgn
force-pushed
the
support_complex_selector_in_not
branch
from
2c15198
to
60a4266
Compare
|
I've found that at least the Chrome developer console supports this selector, so you can test it on something like: <!DOCTYPE html>
<html lang="en">
<head>
<meta charset="UTF-8">
<title>Title</title>
</head>
<body>
<p>
<span a="1"></span>
<span a="2"></span>
<span a="3"></span>
</p>
<div>
<span a="1"></span>
</div>
</body>
</html> |
annbgn
force-pushed
the
support_complex_selector_in_not
branch
from
60a4266
to
90d2eee
Compare
wRAR
reviewed
Aug 17, 2021
| "*[not([a] and following-sibling::*[b])]" | ||
| ) # select anything that is not b or doesn't have a sibling a | ||
| assert xpath("*:not(a b)") == ( | ||
| '*[not(name()="b" and ancestor::*[name()="a"])]' |
There was a problem hiding this comment.
This change should also be applied to other 3 combinators.
There was a problem hiding this comment.
So I suppose the tests should look like this:
assert xpath("*:not(a > b)") == '*[not(name()="b" and parent::*[name()="a"])]' # select anything that is not b or doesn't have a parent a
assert xpath("*:not(a + b)") == '*[not(name()="b" and following-sibling::*[position()=1 and name()="a"])]' # select anything that is not b or doesn't have an immediate sibling a
assert xpath("*:not(a ~ b)") == '*[not(name()="b" and following-sibling::*[name()="a"])]' # select anything that is not b or doesn't have a sibling a
assert xpath("*:not(a b)") == '*[not(name()="b" and ancestor::*[name()="a"])]' # select anything that is not b or doesn't have an ancestor a
please correct me if i'm wrong
annbgn
force-pushed
the
support_complex_selector_in_not
branch
from
90d2eee
to
3c86499
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#51
done: parse complex selector, with any type of combinators (
>,+,~,this pr also includes code from pr to support
:has()pseudo class