New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

always use cython to genearate _htmlpage.c (#112) #122

Open

milahu wants to merge 2 commits into scrapy:master from milahu:use-cython-to-generate-c

milahu commented Apr 4, 2022 •

edited

Loading

fix #112 #113 #121 #118 #116

having scrapely/_htmlpage.c in git makes no sense
instead, generate it from scrapely/_htmlpage.pyx

milahu force-pushed the use-cython-to-generate-c branch from 574a57a to fe7bd32 Compare

April 4, 2022 10:33


          always use cython to genearate _htmlpage.c and _similarity.c (scrapy#112

da2325d

milahu force-pushed the use-cython-to-generate-c branch from fe7bd32 to da2325d Compare

April 4, 2022 10:37

milahu changed the title ~~use cython to genearate _htmlpage.c (#112)~~ always use cython to genearate _htmlpage.c (#112)


          fix test: json.load: unexpected keyword argument 'encoding'

c199c88

milahu mentioned this pull request

Fix portia_server scrapinghub/portia#921

Draft

7 tasks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet