-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DT Support #24
DT Support #24
Conversation
The Memory interfaces are causing a problem at the moment. Shall I define the index signature? will that work how we want? |
Current linter errors:
|
Typing them using the index signatures might work, but we might just move the problem back a stage where if someone wants to include another interface inside of it, still not sure if it plays well w/ a type of We could create some test cases for that, I guess. |
I've disabled a couple of rules that were causing problems.
Tests fail now but I wonder if we need to run |
Makes the required edits to @PostCrafter s PR to support the new dt version
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
DT has finally merged our PR, so we're gonna merge this as well.
Brief Description
Restructure for DT.
Replaces our linter config with the dtlint config. Moves tests into the dist folder. Changes compile to concat so that
tsc
doesn't mess with line lengths etc...Checklists