Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DT Support #24

Merged
merged 8 commits into from
Dec 18, 2017
Merged

DT Support #24

merged 8 commits into from
Dec 18, 2017

Conversation

Arcath
Copy link
Contributor

@Arcath Arcath commented Dec 12, 2017

Brief Description

Restructure for DT.

Replaces our linter config with the dtlint config. Moves tests into the dist folder. Changes compile to concat so that tsc doesn't mess with line lengths etc...

Checklists

  • Test passed
  • Coding style (indentation, etc)

@Arcath
Copy link
Contributor Author

Arcath commented Dec 12, 2017

The Memory interfaces are causing a problem at the moment.

Shall I define the index signature? will that work how we want?

@Arcath
Copy link
Contributor Author

Arcath commented Dec 12, 2017

Current linter errors:

ERROR: 1:1      dt-header                        Header should only be in `index.d.ts`. See: https://github.com/Microsoft/dtslint/blob/master/docs/dt-header.md
ERROR: 10:1     dt-header                        TypeScript version should be specified under header in `index.d.ts`. See: https://github.com/Microsoft/dtslint/blob/master/docs/dt-header.md
ERROR: 2055:11  no-empty-interface               An empty interface is equivalent to `{}`.
ERROR: 2056:11  no-empty-interface               An empty interface is equivalent to `{}`.
ERROR: 2057:11  no-empty-interface               An empty interface is equivalent to `{}`.
ERROR: 2058:11  no-empty-interface               An empty interface is equivalent to `{}`.
ERROR: 3800:1   strict-export-declare-modifiers  'declare' keyword is redundant here. See: https://github.com/Microsoft/dtslint/blob/master/docs/strict-export-declare-modifiers.md
ERROR: 3819:1   strict-export-declare-modifiers  'declare' keyword is redundant here. See: https://github.com/Microsoft/dtslint/blob/master/docs/strict-export-declare-modifiers.md

@resir014
Copy link
Member

@Arcath

Shall I define the index signature? will that work how we want?

Typing them using the index signatures might work, but we might just move the problem back a stage where if someone wants to include another interface inside of it, still not sure if it plays well w/ a type of { [key: string]: any }

We could create some test cases for that, I guess.

@Arcath
Copy link
Contributor Author

Arcath commented Dec 12, 2017

I've disabled a couple of rules that were causing problems.

Tests fail now but I wonder if we need to run tsc anymore. dtslint seems to pick up on compile errors.

Copy link
Member

@resir014 resir014 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DT has finally merged our PR, so we're gonna merge this as well.

@resir014 resir014 merged commit 3d5ec5b into master Dec 18, 2017
@dmarcuse dmarcuse deleted the dt-lint branch March 17, 2018 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants