Skip to content

Commit

Permalink
feat(2683): nodejs upgrade (#43)
Browse files Browse the repository at this point in the history
BREAKING CHANGE: Node 18 upgrade && eslint upgrade
  • Loading branch information
klu909 authored Nov 28, 2022
1 parent 7184ed8 commit e655431
Show file tree
Hide file tree
Showing 3 changed files with 10 additions and 12 deletions.
6 changes: 2 additions & 4 deletions index.js
Original file line number Diff line number Diff line change
Expand Up @@ -17,11 +17,9 @@ class ArtifactBookend extends BookendInterface {
constructor(storeUrl) {
super();
this.storeUrl = storeUrl;
/* eslint-disable max-len */
this.teardownCommands = COMMANDS.replace(new RegExp('\\$ARTIFACTS_DIR_SUFFIX', 'g'), ARTIFACTS_DIR_SUFFIX)
.replace(new RegExp('\\$STORE_URL', 'g'), storeUrl)
this.teardownCommands = COMMANDS.replace(/\\\\\$ARTIFACTS_DIR_SUFFIX/g, ARTIFACTS_DIR_SUFFIX)
.replace(/\\\\\$STORE_URL/g, storeUrl)
.split('\n');
/* eslint-enable max-len */
}

/**
Expand Down
14 changes: 7 additions & 7 deletions package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "screwdriver-artifact-bookend",
"version": "1.0.0",
"version": "2.0.0",
"description": "sd.cd bookend for uploading artifacts",
"main": "index.js",
"scripts": {
Expand Down Expand Up @@ -30,16 +30,16 @@
"Tiffany Kyi <[email protected]>"
],
"devDependencies": {
"chai": "^4.3.4",
"eslint": "^7.5.0",
"eslint-config-screwdriver": "^5.0.1",
"mocha": "^8.2.1",
"chai": "^4.3.7",
"eslint": "^8.28.0",
"eslint-config-screwdriver": "^7.0.0",
"mocha": "^10.1.0",
"mocha-multi-reporters": "^1.5.1",
"mocha-sonarqube-reporter": "^1.0.2",
"nyc": "^15.0.0"
"nyc": "^15.1.0"
},
"dependencies": {
"screwdriver-build-bookend": "^3.0.0"
"screwdriver-build-bookend": "^4.0.0"
},
"release": {
"branches": [
Expand Down
2 changes: 1 addition & 1 deletion screwdriver.yaml
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
shared:
image: node:12
image: node:18

jobs:
main:
Expand Down

0 comments on commit e655431

Please sign in to comment.