Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(2683): nodejs upgrade #141

Merged
merged 3 commits into from
Nov 21, 2022
Merged

feat(2683): nodejs upgrade #141

merged 3 commits into from
Nov 21, 2022

Conversation

klu909
Copy link
Contributor

@klu909 klu909 commented Nov 18, 2022

Context

Objective

References

screwdriver-cd/screwdriver#2683

License

I confirm that this contribution is made under the terms of the license found in the root directory of this repository's source tree and that I have the authority necessary to make this contribution on behalf of its copyright owner.

BREAKING CHANGE: Node 18 upgrade && eslint upgrade
Copy link
Member

@tkyi tkyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you update this line as well:

"node": ">=12.0.0"

@tkyi tkyi merged commit f09408d into master Nov 21, 2022
@tkyi tkyi deleted the nodeupgrade branch November 21, 2022 18:51
@sd-buildbot
Copy link

🎉 This PR is included in version 8.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants