feat(data-schema): Add validation for settings #397
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jithine please review |
jithine
reviewed
May 21, 2020
There was a problem hiding this comment.
One of the guiding principles with modular structure for Screwdriver was we leave it to specific libraries for handling logic & validation.
For settings example we should leave validation logic to https://github.com/screwdriver-cd/notifications-slack/
Since these schema is specific for individual plugins, I think it makes more sense to move it under specific libraries. And during validation phase, parser should have a generic way to call individual plugins
|
Closing in favor of screwdriver-cd/notifications-email#29, screwdriver-cd/notifications-slack#32 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Fixes screwdriver-cd/screwdriver#1574
Objective
This PR adds validation for settings in the shared section. Currently the settings has 2 keys
emailandslack. These can have multiple values like arrays of strings of objects. So this is being validated now. Apart from this, a regex for status has been added for status validation.References
screwdriver-cd/screwdriver#1574
License
I confirm that this contribution is made under the terms of the license found in the root directory of this repository's source tree and that I have the authority necessary to make this contribution on behalf of its copyright owner.