fix: rejectUnauthorized

screwdriver-cd · Aug 6, 2021 · f31d2e4 · f31d2e4
1 parent 5ee080d
commit f31d2e4
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 14 deletions.
diff --git a/index.js b/index.js
@@ -320,7 +320,7 @@ class K8sExecutor extends Executor {
             method: 'PUT',
             url: `${apiUri}/v4/builds/${buildId}`,
             headers: { Authorization: `Bearer ${token}` },
-            rejectUnauthorized: false,
+            https: { rejectUnauthorized: false },
             retry: {
                 limit: this.maxAttempts,
                 calculateDelay: ({ computedValue }) => (computedValue ? this.retryDelay : 0)
@@ -365,7 +365,7 @@ class K8sExecutor extends Executor {
             headers: {
                 Authorization: `Bearer ${this.token}`
             },
-            rejectUnauthorized: false,
+            https: { rejectUnauthorized: false },
             context: {
                 caller: '_start'
             }
@@ -416,7 +416,7 @@ class K8sExecutor extends Executor {
             url: `${this.podsUrl}/${podName}/status`,
             method: 'GET',
             headers: { Authorization: `Bearer ${this.token}` },
-            rejectUnauthorized: false,
+            https: { rejectUnauthorized: false },
             retry: {
                 limit: this.maxAttempts,
                 calculateDelay: ({ computedValue }) => (computedValue ? this.retryDelay : 0)
@@ -633,7 +633,7 @@ class K8sExecutor extends Executor {
             headers: {
                 Authorization: `Bearer ${this.token}`
             },
-            rejectUnauthorized: false,
+            https: { rejectUnauthorized: false },
             context: {
                 caller: '_stop'
             }
@@ -726,7 +726,7 @@ class K8sExecutor extends Executor {
             url: this.podsUrl,
             method: 'GET',
             headers: { Authorization: `Bearer ${this.token}` },
-            rejectUnauthorized: false,
+            https: { rejectUnauthorized: false },
             retry: {
                 limit: this.maxAttempts,
                 calculateDelay: ({ computedValue }) => (computedValue ? this.retryDelay : 0)

diff --git a/test/index.test.js b/test/index.test.js
@@ -302,7 +302,7 @@ describe('index', function() {
             headers: {
                 Authorization: 'Bearer api_key'
             },
-            rejectUnauthorized: false,
+            https: { rejectUnauthorized: false },
             context: {
                 caller: '_stop'
             }
@@ -317,8 +317,7 @@ describe('index', function() {
                 .stop({
                     buildId: testBuildId
                 })
-                .then(res => {
-                    console.log('res: ', res);
+                .then(() => {
                     assert.calledWith(requestRetryMock, deleteConfig);
                     assert.calledOnce(requestRetryMock);
                 }));
@@ -404,7 +403,7 @@ describe('index', function() {
                 headers: {
                     Authorization: 'Bearer api_key'
                 },
-                rejectUnauthorized: false,
+                https: { rejectUnauthorized: false },
                 context: {
                     caller: '_start'
                 }
@@ -415,7 +414,7 @@ describe('index', function() {
                 headers: {
                     Authorization: 'Bearer api_key'
                 },
-                rejectUnauthorized: false,
+                https: { rejectUnauthorized: false },
                 context: {
                     caller: 'getPodStatus'
                 },
@@ -431,7 +430,7 @@ describe('index', function() {
                     Authorization: `Bearer ${testToken}`
                 },
                 json: {},
-                rejectUnauthorized: false,
+                https: { rejectUnauthorized: false },
                 context: {
                     caller: 'updateBuild'
                 },
@@ -1147,7 +1146,7 @@ describe('index', function() {
                 headers: {
                     Authorization: 'Bearer api_key'
                 },
-                rejectUnauthorized: false,
+                https: { rejectUnauthorized: false },
                 hooks: { afterResponse: [executor.pendingStatusRetryStrategy] },
                 retry: { limit: MAXATTEMPTS },
                 searchParams: {
@@ -1499,8 +1498,6 @@ describe('index', function() {
 
                 assert.equal(expectedMessage, actualMessage);
             } catch (error) {
-                console.log(error);
-
                 throw new Error('should not fail');
             }
         });