feat(2092): [2] Dropdown build parameters #398
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tkyi
reviewed
Jul 30, 2020
tkyi
reviewed
Jul 30, 2020
|
|
||
| ```yaml | ||
| parameters: | ||
| nameA: "value1" | ||
| nameB: | ||
| value: "value2" | ||
| description: "description of nameB" | ||
| nameC: ["value1", "value2"] |
There was a problem hiding this comment.
should we add that the default will be the first value in the array?
There was a problem hiding this comment.
Yes, and It is important thing. I add about that.
There was a problem hiding this comment.
Hi @tkyi. Is it OK?
Co-authored-by: Tiffany K <[email protected]>
…river-cd/guide into dropdown-parameters
wahapo
approved these changes
Jul 31, 2020
jithine
approved these changes
Jul 31, 2020
tkyi
reviewed
Aug 3, 2020
Co-authored-by: Tiffany K <[email protected]>
kumada626
approved these changes
Aug 4, 2020
tkyi
approved these changes
Aug 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Add feature of screwdriver-cd/screwdriver#2092
Objective
Please merge after screwdriver-cd/ui#575
Add about dropdown build parameters.
References
License
screwdriver-cd/ui#573screwdriver-cd/ui#575
I confirm that this contribution is made under the terms of the license found in the root directory of this repository's source tree and that I have the authority necessary to make this contribution on behalf of its copyright owner.