Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(1961): Response does not need to be JSON parsed #80

Merged
merged 1 commit into from
Sep 7, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions index.js
Original file line number Diff line number Diff line change
Expand Up @@ -1037,9 +1037,7 @@ class BitbucketScm extends Scm {
}

const response = await this.breaker.runCommand(params);

// we will have to parse the body since we are sending a normal FORM POST request
const body = JSON.parse(response.body);
const { body } = response;

if (response.statusCode !== 200) {
throw new Error(`STATUS CODE ${response.statusCode}: ${JSON.stringify(body)}`);
Expand Down
2 changes: 1 addition & 1 deletion test/index.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -2213,7 +2213,7 @@ describe('index', function() {
beforeEach(() => {
const response = {
statusCode: 200,
body: JSON.stringify(testPayloadAccessToken)
body: testPayloadAccessToken
};

requestMock.resolves(response);
Expand Down