fix(3225): organize the return values of _parseHook [3] #91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yakanechi
approved these changes
Oct 21, 2024
y-oksaku
changed the title
tkyi
reviewed
Oct 21, 2024
| @@ -1889,13 +1892,13 @@ describe('index', function () { | |||
| headers['x-event-key'] = 'issue:created'; | |||
|
|
|||
| return scm.canHandleWebhook(headers, testPayloadPush).then(result => { | |||
| assert.isFalse(result); | |||
| assert.isTrue(result); | |||
There was a problem hiding this comment.
Can you update test title from false to true
There was a problem hiding this comment.
Thank you. I fixed it 👍
tkyi
approved these changes
Oct 21, 2024
|
🎉 This PR is included in version 6.0.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Currently, the
_parseHookmethod returns Object or null or throw Error.However, their return values are not properly conditioned.
Objective
Organize the return values by the following:
scmis correct and Screwdriver do actions with the webhook (e.g.pushevent)scmis correct and Screwdriver do nothing (e.g.deleteevent)scmis not correctThen we can handle whether the webhook is correct or not at here.
References
Issue
PR
License
I confirm that this contribution is made under the terms of the license found in the root directory of this repository's source tree and that I have the authority necessary to make this contribution on behalf of its copyright owner.