fix: Exclude unnecessary retries for checking PR mergeability (#193)

screwdriver-cd · Sep 9, 2021 · d753c1c · d753c1c
1 parent feb8766
commit d753c1c
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/index.js b/index.js
@@ -286,8 +286,8 @@ class GithubScm extends Scm {
         try {
             const pullRequestInfo = await this.getPrInfo({ scmUri, token, prNum });
 
-            if (pullRequestInfo.mergeable) {
-                return { success: true, pullRequestInfo };
+            if (pullRequestInfo.mergeable !== null && pullRequestInfo.mergeable !== undefined) {
+                return { success: pullRequestInfo.mergeable, pullRequestInfo };
             }
             if (count >= POLLING_MAX_ATTEMPT - 1) {
                 logger.warn(`Computing mergerbility did not finish. scmUri: ${scmUri}, prNum: ${prNum}`);