Skip to content

Commit

Permalink
fix: Use external sd-request library
Browse files Browse the repository at this point in the history
  • Loading branch information
tkyi committed Jul 27, 2021
1 parent 9e7735c commit 46cf9e3
Show file tree
Hide file tree
Showing 5 changed files with 112 additions and 309 deletions.
4 changes: 2 additions & 2 deletions index.js
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ const Path = require('path');
const Schema = require('screwdriver-data-schema');
const Scm = require('screwdriver-scm-base');
const logger = require('screwdriver-logger');
const got = require('./lib/got');
const request = require('screwdriver-request');

const DEFAULT_AUTHOR = {
avatar: 'https://cd.screwdriver.cd/assets/unknown_user.png',
Expand Down Expand Up @@ -101,7 +101,7 @@ class GitlabScm extends Scm {
// Everything else goes into context
config.context = options;

got(config)
request(config)
.then(function cb() {
// Use "function" (not "arrow function") for getting "arguments"
callback(null, ...arguments);
Expand Down
72 changes: 0 additions & 72 deletions lib/got.js

This file was deleted.

3 changes: 1 addition & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -46,11 +46,10 @@
"dependencies": {
"@hapi/hoek": "^9.2.0",
"circuit-fuses": "^4.1.0",
"got": "^11.8.2",
"joi": "^17.4.1",
"request": "^2.80.0",
"screwdriver-data-schema": "^21.7.0",
"screwdriver-logger": "^1.1.0",
"screwdriver-request": "^1.0.0",
"screwdriver-scm-base": "^7.3.0"
},
"release": {
Expand Down
Loading

0 comments on commit 46cf9e3

Please sign in to comment.