Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(2398): Add rootDir to checkoutUrl [2] #38

Merged
merged 1 commit into from
Apr 7, 2021
Merged

feat(2398): Add rootDir to checkoutUrl [2] #38

merged 1 commit into from
Apr 7, 2021

Conversation

tkyi
Copy link
Member

@tkyi tkyi commented Mar 31, 2021

Context

Would be nice if the pipeline's root directory did not have to be at checkout root.

Objective

This PR:

  • takes in rootDir into account and adds it to the scmUri
  • fixes getFile path
  • update params

References

Related to screwdriver-cd/screwdriver#2398

License

I confirm that this contribution is made under the terms of the license found in the root directory of this repository's source tree and that I have the authority necessary to make this contribution on behalf of its copyright owner.

@tkyi tkyi added the blocked label Mar 31, 2021
@tkyi tkyi removed the blocked label Apr 6, 2021
@tkyi tkyi merged commit 99c1b6b into master Apr 7, 2021
@tkyi tkyi deleted the root branch April 7, 2021 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants