Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Unauthorized users can be allowed to view the private pipeline if the logged-in user's scmContext and the pipeline's scmContext are different (scm-gitlab) #46

Merged
merged 1 commit into from
Nov 13, 2021

Conversation

yoshwata
Copy link
Contributor

@yoshwata yoshwata commented Nov 12, 2021

Context

Same with screwdriver-cd/scm-github#194

Objective

References

License

I confirm that this contribution is made under the terms of the license found in the root directory of this repository's source tree and that I have the authority necessary to make this contribution on behalf of its copyright owner.

@yoshwata yoshwata changed the title Fix scm mismatch Fix: Unauthorized users can be allowed to view the private pipeline if the logged-in user's scmContext and the pipeline's scmContext are different (scm-gitlab) Nov 12, 2021
@tkyi tkyi merged commit d9f7af0 into screwdriver-cd:master Nov 13, 2021
@yoshwata yoshwata deleted the fix-scm-mismatch branch November 13, 2021 01:14
@sd-buildbot
Copy link

🎉 This PR is included in version 2.7.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants