Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(1769): [4] Change data structure for queue-service cooperation #49

Merged

Conversation

yk634
Copy link
Contributor

@yk634 yk634 commented Dec 16, 2021

Context

Change the data structure so that getChangedFiles can be executed from the endpoint /processHooks added in screwdriver-cd/screwdriver#2622.

Objective

  • parseHook
  • getChangedFiles
    • Change to retrieve the changed file with the information received from parseHook.

References

Because of the changes in the data structure, the unit test may fail until the changes in data-schema are published.

data-schema PR
scm-base PR
scm-github PR
screwdriver PR

screwdriver-cd/screwdriver#1769 (comment)

License

I confirm that this contribution is made under the terms of the license found in the root directory of this repository's source tree and that I have the authority necessary to make this contribution on behalf of its copyright owner.

@yk634 yk634 changed the title feat(1769): Change data structure for queue-service cooperation [WIP] feat(1769): Change data structure for queue-service cooperation Dec 16, 2021
@yk634 yk634 changed the title [WIP] feat(1769): Change data structure for queue-service cooperation [WIP] feat(1769): [3] Change data structure for queue-service cooperation Dec 20, 2021
@yk634 yk634 changed the title [WIP] feat(1769): [3] Change data structure for queue-service cooperation feat(1769): [3] Change data structure for queue-service cooperation Dec 20, 2021
@yk634 yk634 changed the title feat(1769): [3] Change data structure for queue-service cooperation feat(1769): [4] Change data structure for queue-service cooperation Dec 21, 2021
@tkyi tkyi merged commit 05c4498 into screwdriver-cd:master Jan 3, 2022
@sd-buildbot
Copy link

🎉 This PR is included in version 2.8.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@tk3fftk tk3fftk deleted the use-queueservice-for-webhook branch January 11, 2022 02:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants