Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(2892): get GitLab user ID #57

Merged
merged 1 commit into from
Jun 20, 2023
Merged

feat(2892): get GitLab user ID #57

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -721,6 +721,7 @@ class GitlabScm extends Scm {
});

return {
id: author.id,
Copy link
Member

@sagar1312 sagar1312 Jun 23, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to update this similar to screwdriver-cd/scm-github#217

id: author.id.toString(),

url: author.web_url,
name: author.name,
username: author.username,
Expand Down
1 change: 1 addition & 0 deletions test/index.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -432,6 +432,7 @@ describe('index', function () {

it('resolves to correct decorated author', () => {
const expected = {
id: 12345,
url: 'https://gitlab.com/batman',
name: 'Batman',
username: 'batman',
Expand Down