fix(3225): handling when the webhook is incorrect [4] #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 21, 2024
yakanechi
approved these changes
Oct 21, 2024
y-oksaku
changed the title
tkyi
reviewed
Oct 21, 2024
index.js
Outdated
|
|
||
| err.statusCode = 400; | ||
|
|
||
| throw err; |
There was a problem hiding this comment.
Thank you. I add a test for this.
tkyi
approved these changes
Oct 21, 2024
|
🎉 This PR is included in version 8.0.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
The
parseHookmethod returnsnullwhen all scm instances do not accept the webhook.So we cannnot know whether the webhook has correct signature at here because
nullis returned too when the webhook type is not supported.Objective
Throw error when all
scminstances do not accept the webhook.It will be able to see correctly that each
scmaccept the webhook or not by the following PRs.Webhook response example
References
Issue
License
I confirm that this contribution is made under the terms of the license found in the root directory of this repository's source tree and that I have the authority necessary to make this contribution on behalf of its copyright owner.