Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

npm request package has been deprecated #1961

Closed
tk3fftk opened this issue Feb 12, 2020 · 3 comments
Closed

npm request package has been deprecated #1961

tk3fftk opened this issue Feb 12, 2020 · 3 comments
Assignees
Labels

Comments

@tk3fftk
Copy link
Member

tk3fftk commented Feb 12, 2020

What happened:
https://www.npmjs.com/package/request

request has been deprecated, see request/request#3142

What you expected to happen:
We need alternative package.

Reference: request/request#3143

@tk3fftk tk3fftk changed the title request package has been deprecated npm request package has been deprecated Feb 26, 2020
@tkyi tkyi added the refactor label Mar 29, 2021
@tkyi
Copy link
Member

tkyi commented Jul 8, 2021

I think this package is created by the same person as the new alternative: https://github.com/mikeal/bent
Might be an easier transition?

@tk3fftk
Copy link
Member Author

tk3fftk commented Jul 9, 2021

I think this package is created by the same person as the new alternative: https://github.com/mikeal/bent

It looks nice. My concern is it a little outdated (last commit is 9 months ago)

axios/axios is looks popular alternative but the version is still under 1.0.0 so there are possibility of breaking changes.
I take a glanced at sindresorhus/got, it provides migration guide from request.
https://github.com/sindresorhus/got/blob/main/documentation/migration-guides.md

nodejs/undici is looks also a candidate of the alternative. It's provided for Node.js by Node.js's commiters.

@tkyi tkyi self-assigned this Jul 16, 2021
@adong
Copy link
Member

adong commented Jul 20, 2021

Just a thought: rather than just swapping the request library, can we use this opportunity to have a thin layer build on top of the yet-to-choose library? In that case, we could just swap the code underneath it and leave the high-level code untouched, in case we need to do it again a few years down the road. 🤔

@jithine jithine closed this as completed Sep 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants