fix: [3] fix the error handling of getCommitSha #2362
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tkyi
reviewed
Mar 1, 2021
tkyi
approved these changes
Mar 1, 2021
MysticDoll
suggested changes
Mar 2, 2021
There was a problem hiding this comment.
Did you read another scm component?
For example, getCommitSha in scm-gitlab checks response by checkResponseError. And this function set response.statusCode to error.code and also set response.body.message to error.message. Therefore the error object from scm-gitlab does not have status member and it is not guaranteed that error.message always has Branch not found in this case.
I think you should make the interfaces of errors in scm component common by using boom.notFound.
itleigns
changed the title
itleigns
changed the title
itleigns
changed the title
MysticDoll
reviewed
Mar 4, 2021
Co-authored-by: Mitsuru Takigahira <[email protected]>
sugarnaoming
reviewed
Mar 5, 2021
plugins/events/create.js
Outdated
| }) | ||
| .catch(err => { | ||
| if (err.status === 404) { | ||
| throw boom.notFound(err); |
There was a problem hiding this comment.
If you use the following code, you may be able to handle errors other than 404 with boom.
throw boom.boomify(err, {statusCode: err.status})
Co-authored-by: Tiffany K <[email protected]>
tkyi
approved these changes
Mar 8, 2021
ibu1224
pushed a commit
to sonic-screwdriver-cd/screwdriver
that referenced
this pull request
Apr 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
If we run a job in a pipeline whose corresponding SCM branch has been deleted, 500 error is thrown.
It is appropriate to throw 404 error in this case so we want to change that way.
Objective
/eventendpoint throws when we run a job in a pipeline whose corresponding SCM branch has been deleted. We set error status as 404.Context
We change the format of the error returned by.getCommitShain this PR so we change the error handling ofgetCommitShaaccordinglyObjective
We change the error handling ofgetCommitSha.We change a test to follow this PR.We add a test in case we run a pipeline with the corresponding SCM branch deleted.We eliminated unnecessary variable assignments in test code for refactoring.Reference
screwdriver-cd/scm-gitlab#36
screwdriver-cd/scm-bitbucket#75
License
I confirm that this contribution is made under a BSD license and that I have the authority necessary to make this contribution on behalf of its copyright owner.