fix: Use unified modal style for toggle job modal #1090
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tkyi
reviewed
Jul 15, 2024
| @@ -18,7 +18,7 @@ export default class PipelineModalToggleJobComponent extends Component { | |||
| async updateJob() { | |||
| const payload = { | |||
| state: | |||
| this.args.toggleAction.toLowerCase() === 'disabled' | |||
| this.args.toggleAction.toLowerCase() === 'disable' | |||
There was a problem hiding this comment.
should this still be disabled?
Suggested change
| this.args.toggleAction.toLowerCase() === 'disable' | |
| this.args.toggleAction.toLowerCase() === 'disabled' |
There was a problem hiding this comment.
It's actually supposed to be disable...it was a bit of a typo/bug when I had initially put it in. The main idea is that the component takes in a verb and the UI changes it to the correct tense for display.
tkyi
approved these changes
Jul 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
#1088 started unifying the new UI modal look and feel. With those changes we can update the newly created modals to use that style.
Objective
Updates the modal to fit into the new look and feel of the new UI. Additionally, fixes a bug with the submit action not triggering the correct API action.
References
screwdriver-cd/screwdriver#3200
License
I confirm that this contribution is made under the terms of the license found in the root directory of this repository's source tree and that I have the authority necessary to make this contribution on behalf of its copyright owner.