feat: Utility for generating tooltip metadata #1095
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tkyi
reviewed
Jul 30, 2024
app/utils/pipeline/graph/tooltip.js
Outdated
Comment on lines
29
to
30
| const externalTriggerMatch = node.name.match(/^~?sd@(\d+):([\w-]+)$/); | ||
| const downstreamTriggerMatch = node.name.match(/^~sd-([\w-]+)-triggers$/); |
There was a problem hiding this comment.
can we set these to constants or use anything from data-schema?
https://github.com/screwdriver-cd/data-schema/blob/master/config/regex.js#L78
There was a problem hiding this comment.
Sadly, I was only able to use one regex in the data schema.
tkyi
reviewed
Jul 30, 2024
tkyi
approved these changes
Aug 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
The new UI does not use ember data and requires extracting tooltip data from the respective API response data. A new tooltip utility class makes this metadata extraction possible.
Objective
Provide a testable utility for extracting tooltip metadata.
References
screwdriver-cd/screwdriver#3200
License
I confirm that this contribution is made under the terms of the license found in the root directory of this repository's source tree and that I have the authority necessary to make this contribution on behalf of its copyright owner.