Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Refactor graph updating #1183

Merged
merged 2 commits into from
Oct 1, 2024
Merged

fix: Refactor graph updating #1183

merged 2 commits into from
Oct 1, 2024

Conversation

minghay
Copy link
Contributor

@minghay minghay commented Oct 1, 2024

Context

Updating an existing graph should be only need to consist of updating the metadata on the build status of nodes and edges and then updating the classes on the existing SVG.

Objective

  1. Refactor the job node in the graph so that the event handler is on the SVG <g> element
  2. Refactor the child element of the SVG <g> element so that the text and title are siblings for easier targeting and updating
  3. Add in a utility function that can update the graph edge on an existing SVG graph
  4. Add in a utility function that can update the graph node on an existing SVG graph
  5. Refactor the V2 graph component to properly update the existing SVG graph as necessary

References

screwdriver-cd/screwdriver#3200

License

I confirm that this contribution is made under the terms of the license found in the root directory of this repository's source tree and that I have the authority necessary to make this contribution on behalf of its copyright owner.

@tkyi tkyi merged commit 4eb4043 into master Oct 1, 2024
2 checks passed
@tkyi tkyi deleted the update-graph-utils branch October 1, 2024 23:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants