Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update card component utilities #1187

Merged
merged 1 commit into from
Oct 11, 2024
Merged

fix: Update card component utilities #1187

merged 1 commit into from
Oct 11, 2024

Conversation

minghay
Copy link
Contributor

@minghay minghay commented Oct 10, 2024

Context

Update the utility functions for the v2 event card component.

Objective

Updates the utility functions for the v2 event card component for some additional improvements around dynamically updating data as needed.

  1. Consolidate the humanize-duration configuration
  2. Extracts logic to a new utility function getFirstCreateTime
  3. Adds a new utility function getRunningDurationText
  4. Adds extra null checking

References

screwdriver-cd/screwdriver#3200

License

I confirm that this contribution is made under the terms of the license found in the root directory of this repository's source tree and that I have the authority necessary to make this contribution on behalf of its copyright owner.

@tkyi tkyi merged commit 193fd45 into master Oct 11, 2024
2 checks passed
@tkyi tkyi deleted the update-card-util branch October 11, 2024 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants