fix(2676): Update validator with provider field #773
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adong
previously approved these changes
Mar 22, 2022
jithine
reviewed
Mar 22, 2022
| @@ -154,4 +154,16 @@ | |||
| </ul> | |||
| </span> | |||
| </div> | |||
| <div class="provider" title="This is the cloud provider you have added to the job for AWS Native builds."> | |||
There was a problem hiding this comment.
perhaps it should say, this is the ...AWS cloud provider configuration...
Also shouldn't this be optional ? only if job.provider exist
There was a problem hiding this comment.
I was just following what the other ones look like
A lot of them are also optional but show up by default on the right
I can change wording, but I think it's a given that it's configuration, right?
There was a problem hiding this comment.
so I think eventually when we support multiple providers, it might make sense to just call it provider 🤔
jithine
approved these changes
Mar 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Provider field is not showing up in validator yet.
Objective
This PR adds provider field to validator.
References
Related to screwdriver-cd/screwdriver#2676
License
I confirm that this contribution is made under the terms of the license found in the root directory of this repository's source tree and that I have the authority necessary to make this contribution on behalf of its copyright owner.