Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(3176): Use data-schema regex to filter for PR jobs #56

Merged
merged 2 commits into from
Oct 10, 2024
Merged

Conversation

tkyi
Copy link
Member

@tkyi tkyi commented Oct 10, 2024

Context

Currently, job name with : is considered a PR job. So stage@sandbox:teardown is being treated as a PR job. To find the source nodes for join, edges are matched with only "teardown" in the dest, causing stage teardown to run prematurely.

Objective

This PR uses data-schema regex to filter for PR jobs.

References

Related to screwdriver-cd/screwdriver#3176

License

I confirm that this contribution is made under the terms of the license found in the root directory of this repository's source tree and that I have the authority necessary to make this contribution on behalf of its copyright owner.

@tkyi tkyi merged commit fd47bfd into master Oct 10, 2024
2 checks passed
@tkyi tkyi deleted the fixPrCheck branch October 10, 2024 20:14
@sd-buildbot
Copy link

🎉 This PR is included in version 5.0.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants