fix(3176): Use data-schema regex to filter for PR jobs

lib/getSrcForJoin.js

@@ -1,5 +1,7 @@
 'use strict';
 
+const { PR_JOB_NAME } = require('screwdriver-data-schema').config.regex;
+
 /**
  * Find the non PR job from given workflowGragh and dest job
  * @method findJob
@@ -21,15 +23,15 @@ function findJobs(workflowGraph, destJobName) {
 
 /**
  * Find the PR job from given workflowGragh and dest job
- * Given dest job includes `PR-{PR number}:` prefix, so it need to remove prefix at first
+ * Since the dest job has a `PR-{PR number}:` prefix, remove prefix first
  * @method findPRJobs
  * @param  {Object} workflowGraph       Directed graph representation of workflow
  * @param  {String} destJobName         The dest job name to be triggered after a join
  * @return {Set}                        List of node object consists of job name and id
  */
 function findPRJobs(workflowGraph, destJobName) {
     const jobs = new Set();
-    const [prPrefix, prJobName] = destJobName.split(':');
+    const [, prPrefix, prJobName] = destJobName.match(PR_JOB_NAME);
 
     workflowGraph.edges.forEach(edge => {
         if (edge.dest === prJobName && edge.join) {
@@ -47,14 +49,14 @@ function findPRJobs(workflowGraph, destJobName) {
 }
 
 /**
- * Return PR job or not
- * PR job name certainly has ":". e.g. "PR-1:jobName"
+ * Return if PR job or not
+ * PR job name should match regex used in data-schema. e.g. "PR-1:jobName"
  * @method isPR
  * @param  {String}  destJobName       The dest job name which has 'PR-{num}:' prefix
  * @return {Boolean}
  */
 function isPR(destJobName) {
-    return destJobName.includes(':');
+    return PR_JOB_NAME.test(destJobName);
 }
 
 /**

test/lib/getSrcForJoin.test.js

@@ -58,10 +58,13 @@ describe('isPR', () => {
 
     it('sholud return true if job name has PR prefix', () => {
         assert.isTrue(isPR('PR-1:testJobName'));
+        assert.isTrue(isPR('PR-1'));
     });
 
     it('sholud return false if job name does not have PR prefix', () => {
         assert.isFalse(isPR('testJobName'));
+        assert.isFalse(isPR('sd@123:component'));
+        assert.isFalse(isPR('stage@sandbox:teardown'));
     });
 });